Skip to content

Simplify configmanagement integration tests#3295

Merged
pedrottimark merged 1 commit intomasterfrom
cypress-configmanagement-simplify
Oct 4, 2022
Merged

Simplify configmanagement integration tests#3295
pedrottimark merged 1 commit intomasterfrom
cypress-configmanagement-simplify

Conversation

@pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Oct 4, 2022

Description

Follow up with improvements not included to minimize changed lines in #3268

  1. Simplify test file description.
  2. Replace repeated strings with entitiesKey variable.
  3. Split tests which have pair of config blocks into pairs of tests.

Checklist

  • Investigated and inspected CI test results
  • Edited integration tests

Testing Performed

@ghost
Copy link

ghost commented Oct 4, 2022

Images are ready for the commit at 2d78b58.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-207-g2d78b58f9e.

@pedrottimark pedrottimark requested a review from vjwilson October 4, 2022 13:09
Copy link
Contributor

@vjwilson vjwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pedrottimark pedrottimark merged commit 545d3aa into master Oct 4, 2022
@pedrottimark pedrottimark deleted the cypress-configmanagement-simplify branch October 4, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants