Skip to content

ROX-13011: Prevent failures because no controls in configmanagement integration tests#3358

Merged
pedrottimark merged 1 commit intomasterfrom
ROX-13011-cypress-configmanagement-no-controls
Oct 7, 2022
Merged

ROX-13011: Prevent failures because no controls in configmanagement integration tests#3358
pedrottimark merged 1 commit intomasterfrom
ROX-13011-cypress-configmanagement-no-controls

Conversation

@pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Oct 7, 2022

Description

Test failures

Several test failures since 10-03 merge of #3268

  1. 1577432122728124416 from master build on 10-04
  2. 1577952133469179904 from master build on 10-07
  3. 1578271804542160896 from master build on 10-08
  4. 1578281493262766080 from master build on 10-08
  5. 1578352127816765440 from master build on 10-08
  6. 1578399067069747200 from master build on 10-08

Analysis

  1. /main/configmanagement/clusters has No Controls text instead of link.
  2. /main/configmanagement/controls does not have widget in side panel for control.

Prevent failures, pending investigation into reason why No Controls for clusters or nodes.

Changed files

  1. Edit cypress/helpers/configWorkflowUtils.js
    • Delete cy.get(configManagementSelectors.widgets) because helper function encapsulates an entity-specific DOM assertion.
  2. Edit cypress/integration/configmanagement/clusters.test.js
    • Add comment and skip to 'should open the side panel to show the same number of Controls when the Controls link is clicked' test.

Checklist

  • Investigated and inspected CI test results
  • Edited integration tests

Testing Performed

@pedrottimark pedrottimark changed the title Prevent failures because no controls in configmanagement integration tests ROX-13011: Prevent failures because no controls in configmanagement integration tests Oct 7, 2022
@ghost
Copy link

ghost commented Oct 7, 2022

Images are ready for the commit at 917d6b7.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-253-g917d6b786e.

@pedrottimark pedrottimark requested a review from vjwilson October 7, 2022 19:44
Copy link
Contributor

@vjwilson vjwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pedrottimark pedrottimark merged commit f5bf9d4 into master Oct 7, 2022
@pedrottimark pedrottimark deleted the ROX-13011-cypress-configmanagement-no-controls branch October 7, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants