Images are ready for the commit at a188490.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-523-ga1884901cf.

I'd like to additionally ask you to change the following:

Currently, the logic within pkg/scanners/clairify/clairify.go relies on the GetGrpcEndpoint to be unset for the default scanner that we configure. However it would be nice to set the GrpcEndpoint when creating the default integration, i.e. this part within central/imageintegration/store/default.go.

Note, however, that we do not update existing integrations when starting central. We also cannot write a migration for it, since the value for the grpc endpoint is dynamic and depends on the env.Namespace.Setting. So the code path within pkg/scanners/clarify/clairify.go is still required.

Is my understanding correct that you are suggesting to configure the conf *storage.ClairifyConfig.GrpcEndpoint instead of hardcoding the scanner endpoint?
I never worked with any of that code, because of that I am careful to implement such changes which may impact other areas of the code.

@SimonBaeumer Essentially, the code would be extended to the following (code lines as reference):

		IntegrationConfig: &storage.ImageIntegration_Clairify{
			Clairify: &storage.ClairifyConfig{
				Endpoint: fmt.Sprintf("https://%s:8080", scannerEndpoint),
                                 GrpcEndpoint: fmt.Sprintf("%s:8080", scannerEndpoint),
			},
		},

It would still be "hardcoded", so no substantial changes IMO.

@SimonBaeumer Essentially, the code would be extended to the following (code lines as reference):

		IntegrationConfig: &storage.ImageIntegration_Clairify{
			Clairify: &storage.ClairifyConfig{
				Endpoint: fmt.Sprintf("https://%s:8080", scannerEndpoint),
                                 GrpcEndpoint: fmt.Sprintf("%s:8080", scannerEndpoint),
			},
		},

It would still be "hardcoded", so no substantial changes IMO.

@dhaus67 Documented the behaviour of the default that it is added to the image integration's database entry and loaded the namespace dynamically to setup gRPC endpoints.

I did not set the gRPC endpoint on struct creation because the call is a constructor call which sets a default gRPC endpoint automatically already.
By adding the gRPC endpoint to the parameter list we essentially only duplicate the default without providing value, instead it may confuse other engineers later who read the code because the default path may never be reached.

@SimonBaeumer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.