Fix shell check linter for deploy/common/deploy.sh#3547
Fix shell check linter for deploy/common/deploy.sh#3547gavin-stackrox merged 7 commits intostackrox:masterfrom
Conversation
|
Hi @lavanyajain. Thanks for your PR. I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
Images are ready for the commit at ecee59d. To use with deploy scripts, first |
|
@janisz @tommartensen @gavin-stackrox - Requesting for PR review. Thanks :) |
|
@janisz @tommartensen @gavin-stackrox - Requesting for PR review. Thanks :) |
deploy/common/deploy.sh
Outdated
| [[ -f "$license_file" ]] || { echo "License file $license_file not found!" ; return 1 ; } | ||
|
|
||
| local tmp="$(mktemp)" | ||
| tmp="$(mktemp)" |
There was a problem hiding this comment.
This change will convert "tmp" to global variable. (Before this change, it was a local variable). Is this intended change?
There was a problem hiding this comment.
@dastgirp Makes sense to update tmp to be a local variable. Similarly refined and validated all other variable definitions to retain its original state.
|
@gavin-stackrox PTAL |
|
@gavin-stackrox @janisz I see both of you approved this PR. Can you help me in merging this? |
Description
Fix shell check linter for deploy/common/deploy.sh as a part of this defect - Fix shell check linter for deploy/common/deploy.sh
Checklist
If any of these don't apply, please comment below.
Testing Performed
$ shellcheck myscript
No issues detected!