Skip to content

shellcheck fixes for helmdiff.sh#3551

Merged
janisz merged 1 commit intostackrox:masterfrom
dastgirp:fix/3544/helmdiff
Oct 26, 2022
Merged

shellcheck fixes for helmdiff.sh#3551
janisz merged 1 commit intostackrox:masterfrom
dastgirp:fix/3544/helmdiff

Conversation

@dastgirp
Copy link
Contributor

@dastgirp dastgirp commented Oct 25, 2022

Description

Shell checks were ignored for file: dev-tools/helmdiff.sh, this PR fixes the warnings provided by shellcheck (#3544 )

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Above doesn't apply, logic of script isn't changed

Testing Performed

executed command "make shell-style"

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2022

Hi @dastgirp. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the external-contributor To put on issues and PRs from external contributors label Oct 25, 2022
@dastgirp dastgirp changed the title Fixed shell check lint for dev-tools/helmdiff.sh Fixed shellcheck lint for dev-tools/helmdiff.sh Oct 25, 2022
@dastgirp dastgirp changed the title Fixed shellcheck lint for dev-tools/helmdiff.sh shellcheck fixes for helmdiff.sh Oct 25, 2022
@janisz janisz mentioned this pull request Oct 25, 2022
Open
96 tasks
@gavin-stackrox
Copy link
Contributor

gavin-stackrox commented Oct 25, 2022

/ok-to-test

@ghost
Copy link

ghost commented Oct 25, 2022

Images are ready for the commit at 9ed1bb0.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-400-g9ed1bb000a.

@janisz janisz merged commit e62f488 into stackrox:master Oct 26, 2022
ivan-degtiarenko pushed a commit that referenced this pull request Nov 5, 2022
@dastgirp @ivan-degtiarenko
Fixed shell check lint for dev-tools/helmdiff.sh (#3551)
eaee0d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

@ebensh ebensh Awaiting requested review from ebensh

+1 more reviewer

@gavin-stackrox gavin-stackrox gavin-stackrox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external-contributor To put on issues and PRs from external contributors ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dastgirp @gavin-stackrox @janisz