Skip to content

shellcheck fixes for expand-db.sh#3553

Merged
janisz merged 1 commit intostackrox:masterfrom
dastgirp:fix/3544/expanddb
Oct 26, 2022
Merged

shellcheck fixes for expand-db.sh#3553
janisz merged 1 commit intostackrox:masterfrom
dastgirp:fix/3544/expanddb

Conversation

@dastgirp
Copy link
Contributor

@dastgirp dastgirp commented Oct 25, 2022

Description

Shell checks were ignored for file: local/expand-db.sh file, this PR fixes the warnings provided by shellcheck (#3544)

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

executed command "make shell-style"

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2022

Hi @dastgirp. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the external-contributor To put on issues and PRs from external contributors label Oct 25, 2022
@janisz janisz mentioned this pull request Oct 25, 2022
Open
96 tasks
@gavin-stackrox
Copy link
Contributor

gavin-stackrox commented Oct 25, 2022

/ok-to-test

gavin-stackrox
gavin-stackrox approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@gavin-stackrox gavin-stackrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost
Copy link

ghost commented Oct 25, 2022

Images are ready for the commit at 6d8a7e3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-400-g6d8a7e3d2d.

@janisz
Copy link
Contributor

janisz commented Oct 26, 2022

/retest

@janisz janisz merged commit 9b1d5c1 into stackrox:master Oct 26, 2022
ivan-degtiarenko pushed a commit that referenced this pull request Nov 5, 2022
@dastgirp @ivan-degtiarenko
shellcheck lint fix for expand-db.sh (#3553)
6272819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

@connorgorman connorgorman Awaiting requested review from connorgorman

+1 more reviewer

@gavin-stackrox gavin-stackrox gavin-stackrox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external-contributor To put on issues and PRs from external contributors ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dastgirp @gavin-stackrox @janisz