Skip to content

Fixing deploy/k8s/central.sh#3581

Closed
someoneme wants to merge 2 commits intostackrox:masterfrom
someoneme:hahuja
Closed

Fixing deploy/k8s/central.sh#3581
someoneme wants to merge 2 commits intostackrox:masterfrom
someoneme:hahuja

Conversation

@someoneme
Copy link
Contributor

@someoneme someoneme commented Oct 26, 2022

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.

In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2022

Hi @someoneme. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the external-contributor To put on issues and PRs from external contributors label Oct 26, 2022
@someoneme someoneme marked this pull request as ready for review October 26, 2022 21:07
@janisz janisz mentioned this pull request Oct 27, 2022
Open
96 tasks
@janisz
Copy link
Contributor

janisz commented Oct 27, 2022

/ok-to-test

@janisz
Copy link
Contributor

janisz commented Oct 27, 2022

/ok-to-test

@ghost
Copy link

ghost commented Oct 27, 2022

Images are ready for the commit at 1cf4665.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-419-g1cf4665aee.

@janisz
Copy link
Contributor

janisz commented Oct 27, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2022

@someoneme: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/grouped-static-checks 1cf4665 link true /test grouped-static-checks
ci/prow/style-checks 1cf4665 link true /test style-checks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@someoneme someoneme closed this Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavin-stackrox gavin-stackrox Awaiting requested review from gavin-stackrox

@janisz janisz Awaiting requested review from janisz

@tommartensen tommartensen Awaiting requested review from tommartensen

Assignees

No one assigned

Labels

external-contributor To put on issues and PRs from external contributors ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@someoneme @janisz