Conversation
|
Images are ready for the commit at 848902d. To use with deploy scripts, first |
pedrottimark
approved these changes
Oct 28, 2022
Contributor
pedrottimark
left a comment
There was a problem hiding this comment.
Yeah, complicated :(
- The left shift key did not know what the right shift key was doing:
- Generic
skipTLSVerifysee https://github.com/stackrox/stackrox/blob/master/proto/storage/notifier.proto#L110 - Syslog
skipTlsVerifysee https://github.com/stackrox/stackrox/blob/master/proto/storage/notifier.proto#L141-L142
- Generic
- Too bad, so sad. Incorrect local type instead of import correct frontend proto type:
https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/types/notifier.proto.ts#L88
bradr5
approved these changes
Oct 28, 2022
Contributor
Author
I let the Core Workflows team know about #1, but I'd rather not change it that now that it's "out in the wild". I removed the locally defined type for this integration, in favor of that import, which addresses #2 for this file. |
ivan-degtiarenko
pushed a commit
that referenced
this pull request
Nov 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Casing is hard. Fixes a casing typo in one of the fields in the Generic Webhook integration objection.
Checklist
Testing Performed
Manual testing
