Distinguish queries with same opname in compliance integration tests#3627
Merged
pedrottimark merged 2 commits intomasterfrom Oct 31, 2022
Merged
Distinguish queries with same opname in compliance integration tests#3627pedrottimark merged 2 commits intomasterfrom
pedrottimark merged 2 commits intomasterfrom
Conversation
|
Images are ready for the commit at cde853b. To use with deploy scripts, first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prerequisite to simplify integration test configuration to intercept requests and wait for responses:
requestConfig: { opnameAliasesMap, routeMatcherMap }routeMatcherMapgetAggregatedResults
Before changes, same opname requires payload predicate:
"variables": { "groupBy": ["STANDARD", "CLUSTER"], "unit": "CHECK" }"variables": { "groupBy": ["STANDARD", "NAMESPACE"], "unit": "CHECK" }"variables": { "groupBy": ["STANDARD", "CLUSTER"], "unit": "CHECK" }"variables": { "groupBy": ["STANDARD", "NODE"], "unit": "CHECK" }After changes, distinct opnames include prepositional phrase and entity type:
getAggregateResultsAcrossEntity_CLUSTERgetAggregateResultsByEntity_CLUSTERgetAggregateResultsAcrossEntity_NAMESPACEgetAggregateResultsAcrossEntity_NODEcomplianceStandards
Before changes, same opname requires payload predicate:
where: "Standard:CIS Docker v1.2.0"where: "Standard:"CIS Kubernetes v1.5"where: "Standard:"HIPAA 164"where: "Standard:"NIST SP 800-190"where: "Standard:"NIST SP 800-53"where: "Standard:"PCI DSS 3.2.1"After changes, distinct opnames include standard id:
complianceStandards_CIS_Docker_v1_2_0complianceStandards_CIS_Kubernetes_v1_5complianceStandards_HIPAA_164complianceStandards_NIST_800_190complianceStandards_NIST_SP_800_53_Rev_4complianceStandards_PCI_DSS_3_2Checklist
Testing Performed