Skip to content

🚨 G113 gosec rule enabled#3631

Merged
janisz merged 2 commits intostackrox:masterfrom
bgalek:G113
Nov 2, 2022
Merged

🚨 G113 gosec rule enabled#3631
janisz merged 2 commits intostackrox:masterfrom
bgalek:G113

Conversation

@bgalek
Copy link
Contributor

@bgalek bgalek commented Oct 30, 2022

Description

G113 check enabled in gosec config

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2022

Hi @bgalek. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the external-contributor To put on issues and PRs from external contributors label Oct 30, 2022
@janisz
Copy link
Contributor

janisz commented Nov 2, 2022

/ok-to-test

@janisz janisz mentioned this pull request Nov 2, 2022
Open
34 tasks
@ghost
Copy link

ghost commented Nov 2, 2022 •
edited by ghost
Loading

Images are ready for the commit at 6e898f5.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-473-g6e898f55b0.

@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2022

@bgalek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-postgres-qa-e2e-tests d2337a1 link false /test gke-postgres-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz
Copy link
Contributor

janisz commented Nov 2, 2022

/retest

@janisz janisz enabled auto-merge (squash) November 2, 2022 15:08
@janisz janisz merged commit 9fbcb26 into stackrox:master Nov 2, 2022
ivan-degtiarenko pushed a commit that referenced this pull request Nov 5, 2022
@bgalek @janisz @ivan-degtiarenko
G113 gosec rule enabled (#3631)
03744f8 
Co-authored-by: Tomasz Janiszewski <tomek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

Assignees

No one assigned

Labels

external-contributor To put on issues and PRs from external contributors ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bgalek @janisz