Extract collection fetching code into hook#3746
Merged
dvail merged 1 commit intodv/collections-extract-form-from-drawerfrom Nov 10, 2022
Merged
Extract collection fetching code into hook#3746dvail merged 1 commit intodv/collections-extract-form-from-drawerfrom
dvail merged 1 commit intodv/collections-extract-form-from-drawerfrom
Conversation
|
Skipping CI for Draft Pull Request. |
This was referenced Nov 8, 2022
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
5 tasks
af904f2 to
305d20b
Compare
ce1248d to
e5ac8cf
Compare
305d20b to
3a90073
Compare
e5ac8cf to
ec29509
Compare
3a90073 to
20e0d73
Compare
ec29509 to
9efeb2a
Compare
pedrottimark
approved these changes
Nov 9, 2022
Contributor
pedrottimark
left a comment
There was a problem hiding this comment.
Aha, after important decision that modal is a view, then asymmetry is logical outcome:
- Encapsulate read requests in hook for form and modal.
- Import create, delete, update requests in form only.
20e0d73 to
58bc8d4
Compare
9efeb2a to
cf65fef
Compare
This was referenced Nov 10, 2022
58bc8d4 to
eabbc39
Compare
cf65fef to
d0811eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (3 of 3)
This extracts the collection and embedded collection fetching logic into a reusable hook, which will be needed later when we add an independent modal for displaying the collection form.
Checklist