Skip to content

ROX-8948: Add modal for showing image in deferral request#377

Merged
md2119 merged 2 commits intomasterfrom
ROX-8948-add-modal-for-showing-image-in-deferral-request
Jan 20, 2022
Merged

ROX-8948: Add modal for showing image in deferral request#377
md2119 merged 2 commits intomasterfrom
ROX-8948-add-modal-for-showing-image-in-deferral-request

Conversation

@vjwilson
Copy link
Contributor

Description

Minimum version of the Impacted Entities modal for deployments and images of a deferred/false positive CVE in VM risk workflow.

(This gets the structure in, but defers search/sort.)

Checklist

  • Investigated and inspected CI test results

Testing Performed

Manual testing with test server data

Screen Shot 2022-01-19 at 5 52 46 PM

Screen Shot 2022-01-19 at 5 52 54 PM

@vjwilson vjwilson added the pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted label Jan 19, 2022
@ghost
Copy link

ghost commented Jan 19, 2022

Tag for build #122364 is 3.67.x-342-g5c282fb368.

💻 For deploying this image using the dev scripts, run the following first:

export MAIN_IMAGE_TAG='3.67.x-342-g5c282fb368'

📦 You can also generate an installation bundle with:

docker run -i --rm stackrox/main:3.67.x-342-g5c282fb368 central generate interactive > bundle.zip

🕹️ A roxctl binary artifact can be downloaded from CircleCI.

Copy link
Contributor

@md2119 md2119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will defer the code review to UI folks but the graphQL query and the modal is 👍 from me.

Copy link
Contributor

@sachaudh sachaudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for what we need for release 👍🏼

@md2119
Copy link
Contributor

md2119 commented Jan 20, 2022

@vjwilson, tagged it with plz-merge, therefore, taking the liberty to merge this request.

@md2119 md2119 merged commit e69a800 into master Jan 20, 2022
@md2119 md2119 deleted the ROX-8948-add-modal-for-showing-image-in-deferral-request branch January 20, 2022 00:25
RTann pushed a commit that referenced this pull request Apr 6, 2022
* ROX-8948: Add modal for showing image in deferral request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants