[ROX-13525] : Change getCollectionCount endpoint and updateCollection request type#3792
Merged
charmik-redhat merged 1 commit intomasterfrom Nov 14, 2022
Conversation
Contributor
Author
|
/retest |
Contributor
Author
|
/test all |
keyallis
approved these changes
Nov 11, 2022
Contributor
|
Lets make sure we manually verify that the endpoints can be invoked as expected and we have a green CI before merging |
Contributor
Author
|
/retest |
|
Images are ready for the commit at d3efb62. To use with deploy scripts, first |
5 tasks
md2119
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GetCollectionCount endpoint changed to
/v1/collectionscountUpdateCollection request type changed to
PATCHChecklist
[ ] Unit test and regression tests added[ ] Evaluated and added CHANGELOG entry if required[ ] Determined and documented upgrade steps[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed
Did manual testing of create, update, get, list, getCount and delete endpoints
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.