ROX-13326: Access control UUID support in the UI#3818
Merged
rhybrillou merged 3 commits intoyann/ROX-13326-role_ids_as_uuidsfrom Nov 17, 2022
Merged
ROX-13326: Access control UUID support in the UI#3818rhybrillou merged 3 commits intoyann/ROX-13326-role_ids_as_uuidsfrom
rhybrillou merged 3 commits intoyann/ROX-13326-role_ids_as_uuidsfrom
Conversation
|
Skipping CI for Draft Pull Request. |
2 tasks
vjwilson
approved these changes
Nov 16, 2022
Contributor
vjwilson
left a comment
There was a problem hiding this comment.
It may be nice to include a TODO comment above the constant object's definition, about when the non-Postgres versions could be removed from the code.
janisz
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal here (as started with PRs #3802 and #3725) is to rely on postgres built-in UUID types, which are more compact and can bring performance improvements in data lookups.
Manual testing highlighted a bug when opening the Unrestricted access scope page.
The goal here is to support the hardcoded UUID format too.
PR stack:
#3802 (server support code)
+- #3725 (data migration)
... +- #3818 (UI code)
Checklist
- [ ] Unit test and regression tests added- [ ] Evaluated and added CHANGELOG entry if required- [ ] Determined and documented upgrade steps- [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed
Manual testing:
Unrestrictedaccess scopeThe
Unrestrictedaccess scope has a special internal representation, which requires dedicated handling. The point of the change here is to ensure the dedicated handling also applies to the dedicated UUID identifier.