[ROX-9864] : Sleep after creating deployment to wait for image CVEs being discovered and added to db#3834
Merged
charmik-redhat merged 2 commits intomasterfrom Nov 23, 2022
Conversation
|
Images are ready for the commit at 86139d1. To use with deploy scripts, first |
clickboo
reviewed
Nov 17, 2022
| } | ||
|
|
||
| @EqualsAndHashCode(includeFields = true) | ||
| @ToString(includeFields = true) |
Contributor
There was a problem hiding this comment.
Nit: Would these cause the log to be very noisy if all cves are being logged?
Contributor
Author
There was a problem hiding this comment.
That is right, I should only include id and cvss since they are relevant to debugging.
Contributor
Author
|
/retest |
9544c37 to
86139d1
Compare
clickboo
approved these changes
Nov 23, 2022
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 11, 2023
…eing discovered and added to db (#3834)
1 task
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 14, 2023
…eing discovered and added to db (#3834)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It seems like the failure occurs when all image CVEs are not yet discovered and added to DB or when their cvss scores are not yet populated. This leads to different imageCVE counts between two graphQL queries, or different sort orders based on cvss score. Also, added a ToString annotation to CVE class used by the test to see better logs if test failure occurs again.
Checklist
If any of these don't apply, please comment below.
Testing Performed
Not needed for a test update.