Skip to content

Adjust columnIndex argument in vulnmanagement integration tests#3900

Merged
pedrottimark merged 3 commits intomasterfrom
cypress-vulnmanagement-columnIndex
Nov 28, 2022
Merged

Adjust columnIndex argument in vulnmanagement integration tests#3900
pedrottimark merged 3 commits intomasterfrom
cypress-vulnmanagement-columnIndex

Conversation

@pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Nov 23, 2022

Description

Follow up residue from #3885

Objective: To prevent confusion.

Because hasTableColumnHeadings function explicitly asserts existence of checkbox, hidden, and invisible column headings:

  1. Make comments more specific.
  2. Increment columnIndex arguments of verify function calls to be consistent with arrays of column heading strings in the function call.
  3. Replace columnIndex + 1 with columnIndex in nth-child pseudo-selector.
    • verifySecondaryEntities
    • verifyFilteredSecondaryEntitiesLink
    • verifyFixableCVEsLinkAndRiskAcceptanceTabs

Checklist

  • Investigated and inspected CI test results
  • Edited integration tests

Testing Performed

@ghost
Copy link

ghost commented Nov 23, 2022

Images are ready for the commit at ae10514.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.73.x-64-gae10514b35.

@pedrottimark pedrottimark merged commit b71d47f into master Nov 28, 2022
@pedrottimark pedrottimark deleted the cypress-vulnmanagement-columnIndex branch November 28, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants