Skip to content

release 3.73.1 fix merge rox 13943 d283709#4172

Merged
davdhacs merged 3 commits intorelease-3.73from
dahouse/release-3.73.1-fix-merge-rox-13943_d283709
Dec 16, 2022
Merged

release 3.73.1 fix merge rox 13943 d283709#4172
davdhacs merged 3 commits intorelease-3.73from
dahouse/release-3.73.1-fix-merge-rox-13943_d283709

Conversation

@davdhacs
Copy link
Contributor

No description provided.

…eature flag (#4160)

minus the changes to central/image/service/service_impl.go
@gitguardian

This comment was marked as outdated.

@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@davdhacs davdhacs changed the base branch from master to release-3.73 December 16, 2022 01:17
@davdhacs davdhacs requested a review from RTann December 16, 2022 01:45
@davdhacs davdhacs marked this pull request as ready for review December 16, 2022 01:46
@davdhacs davdhacs requested a review from BradLugo December 16, 2022 01:50
@RTann RTann requested a review from dhaus67 December 16, 2022 02:05
@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2022

@davdhacs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/stackrox_branding-images d8b99da link true /test stackrox_branding-images
ci/prow/images d8b99da link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Co-authored-by: dhaus67 <dhaus@redhat.com>
@davdhacs davdhacs enabled auto-merge (squash) December 16, 2022 02:33
@davdhacs
Copy link
Contributor Author

@RTann @dhaus67 I'll wait on a review +1 to merge this. It looks ready?

Copy link
Contributor

@dhaus67 dhaus67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Thanks for taking this on @RTann & @davdhacs !

@davdhacs davdhacs merged commit 2a37082 into release-3.73 Dec 16, 2022
@davdhacs davdhacs deleted the dahouse/release-3.73.1-fix-merge-rox-13943_d283709 branch December 16, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants