Skip to content

ROX-13345: Enable back previously flaked test for debugging#4238

Merged
jvdm merged 1 commit intomasterfrom
jvdm/ROX-13345/debug
Jan 11, 2023
Merged

ROX-13345: Enable back previously flaked test for debugging#4238
jvdm merged 1 commit intomasterfrom
jvdm/ROX-13345/debug

Conversation

@jvdm
Copy link
Contributor

@jvdm jvdm commented Dec 21, 2022 •
edited
Loading

Description

This reverts #3798

After running the E2E test a couple of times in this PR, there is some confidence that the tests are passing. This is an attempt to re-enable it. I acknowledge the test failure is intermittent, so it is still possible that the failures will resurface. We will tackle issues before the policy disable this tests again.

Checklist

  • Investigated and inspected CI test results
  • [ ] Unit test and regression tests added
  • [ ] Evaluated and added CHANGELOG entry if required
  • [ ] Determined and documented upgrade steps
  • [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed

CI

@openshift-ci
Copy link

openshift-ci bot commented Dec 21, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ghost
Copy link

ghost commented Dec 21, 2022 •
edited by ghost
Loading

Images are ready for the commit at ed17f4d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.73.x-380-ged17f4de82.

@porridge porridge added the ci-all-qa-tests Tells CI to run all API tests (not just BAT). label Jan 2, 2023
@porridge
Copy link
Contributor

porridge commented Jan 2, 2023

/test all

@jvdm jvdm force-pushed the jvdm/ROX-13345/debug branch from f3cd8a5 to ce20370 Compare January 5, 2023 01:09
@jvdm
Copy link
Contributor Author

jvdm commented Jan 6, 2023

/test all

1 similar comment
@jvdm
Copy link
Contributor Author

jvdm commented Jan 9, 2023

/test all

@jvdm
Copy link
Contributor Author

jvdm commented Jan 10, 2023

/test openshift-newest-qa-e2e-tests

@jvdm
Copy link
Contributor Author

jvdm commented Jan 10, 2023

/test rosa-qa-e2e-tests

@jvdm jvdm changed the title wip: Enable back previously flaked test for debugging Enable back previously flaked test for debugging Jan 10, 2023
@jvdm
Copy link
Contributor Author

jvdm commented Jan 10, 2023

/retest

@jvdm jvdm changed the title Enable back previously flaked test for debugging ROX-13345: Enable back previously flaked test for debugging Jan 10, 2023
@jvdm
Copy link
Contributor Author

jvdm commented Jan 10, 2023

/test osd-gcp-qa-e2e-tests

@jvdm jvdm requested review from RTann and porridge January 11, 2023 01:20
@jvdm jvdm marked this pull request as ready for review January 11, 2023 01:20
@RTann
Copy link
Contributor

RTann commented Jan 11, 2023

I think the submodule change was an accident?

@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023 •
edited
Loading

@jvdm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-postgres-qa-e2e-tests 326f2c4 link false /test gke-postgres-qa-e2e-tests
ci/prow/gke-qa-e2e-tests 326f2c4 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

porridge
porridge approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see some activity on this!
As @RTann mentioned, please revert the submodule bump.

@jvdm jvdm force-pushed the jvdm/ROX-13345/debug branch from 326f2c4 to ed17f4d Compare January 11, 2023 18:59
@jvdm jvdm merged commit 830c059 into master Jan 11, 2023
@jvdm jvdm deleted the jvdm/ROX-13345/debug branch January 11, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@porridge porridge porridge approved these changes

@RTann RTann Awaiting requested review from RTann

Assignees

No one assigned

Labels

ci-all-qa-tests Tells CI to run all API tests (not just BAT).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvdm @porridge @RTann