ROX-14129,ROX-14130,ROX-14131,ROX-14132: Fix failing boolean policy test.#4253
Merged
ROX-14129,ROX-14130,ROX-14131,ROX-14132: Fix failing boolean policy test.#4253
Conversation
Contributor
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
9442b88 to
5af5d8a
Compare
Contributor
Author
|
/retest |
|
Images are ready for the commit at 5af5d8a. To use with deploy scripts, first |
porridge
approved these changes
Jan 2, 2023
Contributor
porridge
left a comment
There was a problem hiding this comment.
Thanks for tracking this down. One nitpick.
| // This test will fail in three years, but if this test still matters then, | ||
| // we have other problems... | ||
| {Field: "BaseTS", Values: []string{">1000d"}}, | ||
| {Field: "BaseTS", Values: []string{">2000d"}}, |
Contributor
There was a problem hiding this comment.
Please change this as well as the comment to 1000y instead (or if that does not fit, 100y).
Contributor
Author
There was a problem hiding this comment.
I oversaw this one before merging, created a follow-up for this: #4255.
Sorry!
Contributor
|
Merge commit has been cherry-picked to branch |
janisz
pushed a commit
that referenced
this pull request
Jan 31, 2023
Merged
Contributor
|
Please merge the changes to branch |
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 11, 2023
1 task
gavin-stackrox
pushed a commit
that referenced
this pull request
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current test failed after three years when it was written, which we now hit :-).
Checklist
- [ ] Unit test and regression tests added- [ ] Evaluated and added CHANGELOG entry if required- [ ] Determined and documented upgrade steps- [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed