ROX-9127: Create CertificateRequester to request certificates from central#455
ROX-9127: Create CertificateRequester to request certificates from central#455
Conversation
|
Tag for build #147884 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.68.x-47-g573bd2887c'📦 You can also generate an installation bundle with: docker run -i --rm stackrox/main:3.68.x-47-g573bd2887c central generate interactive > bundle.zip🕹️ A |
SimonBaeumer
left a comment
There was a problem hiding this comment.
Your PR turn out to be a good async go training, I really enjoy it! Keep up the good work!
As said in a comment this approach does not work if multiple requests are pending. If this happens this could cause the pod running out of memory because on each cert refresh tick a new gorutine is spawned which may never receive the request.
To dispatch the response to the corresponding request an index may needed here.
|
Description
The CertificateRequester to request certificates from central using two channels that can be provided by a SensorComponent, see example usage in draft PR #400
Checklist
No CHANGELOG entry or upgrade steps required.
Testing Performed
Added unit test