ROX-12848: Set Postgres flag to permanently enabled by connorgorman · Pull Request #4690 · stackrox/stackrox

connorgorman · 2023-02-02T20:43:37Z

Description

Sets the Postgres flag to always be the default value of the setting

Tests that need to be ported:

Central/deployment/index/search_comparison_test.go
Central/splunk/violations_test
TestImageLoader - graphql/resolvers/loaders/images_test.go
TestImageIntegrationDataStore - central/imageintegration/datastore/datastore_impl.go
TestProcessBaselineService - central/processbaseline/service/service_impl_test.go
Role/datastore/datastore_test.go

Checklist

Investigated and inspected CI test results
Unit test and regression tests added
Evaluated and added CHANGELOG entry if required
Determined and documented upgrade steps
Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

CI

ghost · 2023-02-02T20:59:43Z

Images are ready for the commit at 6cdef58.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.74.x-76-g6cdef5894a.

gavin-stackrox · 2023-02-03T18:45:16Z

/test openshift-newest-qa-e2e-tests openshift-penultimate-qa-e2e-tests openshift-oldest-qa-e2e-tests

gavin-stackrox · 2023-02-03T19:12:14Z

/test openshift-newest-qa-e2e-tests openshift-penultimate-qa-e2e-tests openshift-oldest-qa-e2e-tests

SimonBaeumer · 2023-02-06T09:51:56Z

scripts/ci/jobs/gke_nongroovy_e2e_tests.py

 from ci_tests import NonGroovyE2e
 from post_tests import PostClusterTest, FinalPost

+# Postgres is on by default


Can you elaborate this comment why these tests are not executed with postgres enabled, instead exit early? I am lacking context to understand this.

Sure, this is because these tests expect Postgres to be off and these are covered by the go version of these tests

SimonBaeumer · 2023-02-06T09:52:04Z

scripts/ci/jobs/gke_upgrade_tests.py

 from post_tests import PostClusterTest, FinalPost

+# Postgres is on by default
+exit(0)


Can you elaborate this comment why these tests are not executed with postgres enabled, instead exit early? I am lacking context to understand this.

I added a better comment

SimonBaeumer · 2023-02-06T09:53:08Z

tests/e2e/run-e2e-tests.sh

-            ;;
        *)
-            die "database $DATABASE not supported"
+            export ROX_POSTGRES_DATASTORE="true"


Can the case block be removed? It looks like export ROX_POSTGRES_DATASTORE="true" is always executed.

SimonBaeumer · 2023-02-06T09:55:07Z

tests/roxctl/bats-tests/local/expect/flavor-interactive.expect.tcl

+# Enter central-db image to use (default: "docker.io/stackrox/central-db:2.21.0-15-g448f2dc8fa"):
+# Enter central-db image to use (default: "stackrox.io/central-db:3.67.x-296-g56df6a892d"):
+# Enter central-db image to use (default: "registry.redhat.io/advanced-cluster-security/rhacs-central-db-rhel8:3.68.x-30-g516b4e7a6c-dirty"):


Are these defaults hardcoded? Where are they coming from?
Especially the -dirty tags looks like a non-default to me because it is mostly build locally and never pushed to a registry.

This is just a comment to illustrate the expect below cases

central/processlisteningonport/datastore/datastore_impl_test.go

janisz

I think this should be splitted into smaller PRs.

Fix go code and prepare it for this change
fix shell and makefile
everything else

openshift-ci · 2023-02-10T06:38:47Z

@connorgorman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/openshift-newest-qa-e2e-tests	`8377bd0`	link	false	`/test openshift-newest-qa-e2e-tests`
ci/prow/openshift-penultimate-qa-e2e-tests	`8377bd0`	link	false	`/test openshift-penultimate-qa-e2e-tests`
ci/prow/openshift-oldest-qa-e2e-tests	`6cdef58`	link	false	`/test openshift-oldest-qa-e2e-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

porridge · 2023-02-10T07:16:30Z

The fact that all openshift-*qa-e2e-tests failed worries me. For example:

Requesting stop of task ':testBAT' as it has exceeded its configured timeout of 3h.

Are we sure these failures are not related to this change @connorgorman ?

connorgorman added the postgres-breaking-change Should be used when the change breaks RocksDB compatibility label Feb 2, 2023

connorgorman requested a review from a team as a code owner February 3, 2023 02:59

github-actions bot added area/central area/postgres labels Feb 3, 2023

connorgorman requested a review from a team as a code owner February 3, 2023 03:33

gavin-stackrox force-pushed the cgorman-flag-always-on branch from eeba4fb to 2f01ef9 Compare February 3, 2023 18:41

connorgorman requested a review from a team as a code owner February 3, 2023 18:42

gavin-stackrox requested a review from a team February 3, 2023 19:11

github-actions bot added the area/operator label Feb 3, 2023

connorgorman force-pushed the cgorman-flag-always-on branch from 822335d to 372fb20 Compare February 3, 2023 22:13

connorgorman mentioned this pull request Feb 5, 2023

Make unit tests pass with ROX_POSTGRES_DATASTORE flag both on and off #4719

Merged

5 tasks

SimonBaeumer suggested changes Feb 6, 2023

View reviewed changes

dashrews78 reviewed Feb 6, 2023

View reviewed changes

central/processlisteningonport/datastore/datastore_impl_test.go Outdated Show resolved Hide resolved

janisz reviewed Feb 6, 2023

View reviewed changes

connorgorman force-pushed the cgorman-flag-always-on branch 2 times, most recently from e2ac78b to 17c7d36 Compare February 8, 2023 18:40

SimonBaeumer approved these changes Feb 9, 2023

View reviewed changes

dashrews78 approved these changes Feb 9, 2023

View reviewed changes

gavin-stackrox force-pushed the cgorman-flag-always-on branch from 1d46472 to b259daf Compare February 9, 2023 15:18

gavin-stackrox requested a review from a team as a code owner February 9, 2023 15:18

github-actions bot added area/roxctl area/helm labels Feb 9, 2023

Connor Gorman and others added 5 commits February 9, 2023 16:50

ROX-12848: Set Postgres flag to permanently enabled

52bc99b

always export ROX_POSTGRES_DATASTORE

851f538

Flip postgres flag to true in all the tests

4047742

fix local roxctl post merge

8fd4c90

space

ff2d7d7

Connor Gorman added 2 commits February 9, 2023 16:50

DB should be enabled on helm by default

fca06b1

Fix tests

fb7bc8c

connorgorman force-pushed the cgorman-flag-always-on branch from 8377bd0 to fb7bc8c Compare February 10, 2023 01:44

one more fix

e499df3

connorgorman enabled auto-merge (squash) February 10, 2023 04:54

generate tests

6cdef58

connorgorman merged commit da708eb into master Feb 10, 2023

connorgorman deleted the cgorman-flag-always-on branch February 10, 2023 06:48

porridge mentioned this pull request Nov 28, 2023

chore(lint): enable the "unused" linter and remove code #8783

Merged

5 tasks

Conversation

connorgorman commented Feb 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Testing Performed

Uh oh!

ghost commented Feb 2, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gavin-stackrox commented Feb 3, 2023

Uh oh!

gavin-stackrox commented Feb 3, 2023

Uh oh!

SimonBaeumer Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

connorgorman Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

SimonBaeumer Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

connorgorman Feb 8, 2023

Choose a reason for hiding this comment

Uh oh!

SimonBaeumer Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

SimonBaeumer Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

connorgorman Feb 8, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

janisz left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 10, 2023

Uh oh!

porridge commented Feb 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

connorgorman commented Feb 2, 2023 •

edited

Loading

ghost commented Feb 2, 2023 •

edited by ghost

Loading