Conversation
|
Images are ready for the commit at 747b9a1. To use with deploy scripts, first |
|
@vjwilson: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
srcporter
reviewed
Mar 20, 2023
Contributor
srcporter
left a comment
There was a problem hiding this comment.
LGTM but i'm hardly the expert.
bradr5
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add code to handle the name for the new Postgres-enabled CVE types to
getEntityNamehook, in fileui/apps/platform/src/utils/getEntityName.jsThis fixes:
UI crash on a postgreSQL 3.74 install. It's pretty consistent, navigating from a particular CVE to the related entities like Deployment.
nav path is VM Dashboard -> Select #3 image in "Top Riskiest" -> Click on CVE-2014-9761 -> 4 Deployments
Analysis
When we split the CVE types for Postgres, an edge case opened in the page heading code, which picks the "name" field based on type. I forgot to add the new CVE types to the header code.
Doesn't matter, except that the fallback of generic name tries to print the image's name, which is nested in an object, as the page transitions from the single image view to the deployment list for a CVE, as one view goes out of scope and the other comes in.
(That's why going straight to the link works--there's no old image view to transition away from.)
Checklist
Testing Performed
Screen recording of this code path working with this code change
no-crash-image-cve-deployments-navigation.mov