Skip to content

Add helmdiff.sh to dev-tools#559

Merged
ebensh merged 6 commits intomasterfrom
evan/add-helmdiff-to-dev-tools
Feb 7, 2022
Merged

Add helmdiff.sh to dev-tools#559
ebensh merged 6 commits intomasterfrom
evan/add-helmdiff-to-dev-tools

Conversation

@ebensh
Copy link
Contributor

@ebensh ebensh commented Feb 4, 2022

Description

A tool to render Helm Metatemplates to Helm charts to dry run installation manifests, providing diff commands for each stage.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps

If any of these don't apply, please comment below.

Testing Performed

Ran the tool, ran the diff commands output, inspected output.

@ghost
Copy link

ghost commented Feb 4, 2022

Tag for build #181888 is 3.68.x-134-g645b3a4a1a.

💻 For deploying this image using the dev scripts, run the following first:

export MAIN_IMAGE_TAG='3.68.x-134-g645b3a4a1a'

📦 You can also generate an installation bundle with:

docker run -i --rm stackrox/main:3.68.x-134-g645b3a4a1a central generate interactive > bundle.zip

🕹️ A roxctl binary artifact can be downloaded from CircleCI.

@ebensh ebensh marked this pull request as ready for review February 4, 2022 14:42
Copy link
Contributor

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to be able to pass "$@" to the helm invocations as well, but I don't know how well this would work with values that only apply to one of the charts. 🤔

helm install --debug --dry-run \
-n stackrox \
--disable-openapi-validation \
--set clusterName=mergers-and-acquisitions \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

ebensh and others added 3 commits February 7, 2022 09:30
Link TODO to ebensh

Co-authored-by: Marcin Owsiany <porridge@redhat.com>
…stackrox into evan/add-helmdiff-to-dev-tools
@ebensh ebensh enabled auto-merge (squash) February 7, 2022 08:50
@ebensh ebensh merged commit 07ffada into master Feb 7, 2022
@ebensh ebensh deleted the evan/add-helmdiff-to-dev-tools branch February 7, 2022 08:53
RTann pushed a commit that referenced this pull request Apr 6, 2022
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants