Skip to content

MITRE refactor phase #2: Moving mitre utils to pkg#5925

Merged
clickboo merged 1 commit intomasterfrom
boo-mitre-phase-2
May 4, 2023
Merged

MITRE refactor phase #2: Moving mitre utils to pkg#5925
clickboo merged 1 commit intomasterfrom
boo-mitre-phase-2

Conversation

@clickboo
Copy link
Contributor

@clickboo clickboo commented May 4, 2023

Description

Moving MITRE utils to pkg

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on [openshift/openshift-docs](https://github.com/openshift/openshift-docs) and merge into rhacs-docs)

Testing Performed

Refactor only, CI

@clickboo clickboo requested a review from a team as a code owner May 4, 2023 20:33
@clickboo clickboo requested a review from keyallis May 4, 2023 20:33
Copy link
Contributor

@keyallis keyallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@keyallis keyallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM take 2

@clickboo clickboo enabled auto-merge (squash) May 4, 2023 20:50
@ghost
Copy link

ghost commented May 4, 2023

Images are ready for the commit at 1ea0499.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.0.x-256-g1ea0499c73.

@clickboo clickboo merged commit daddc48 into master May 4, 2023
@clickboo clickboo deleted the boo-mitre-phase-2 branch May 4, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants