ROX-16515: Temporarily hide dark mode#6432
Merged
Conversation
|
Images are ready for the commit at 2c29cf8. To use with deploy scripts, first |
pedrottimark
approved these changes
Jun 9, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Request from our UX team. (see Jira)
Until we can fully implement PatternFly themes for dark mode.
Checklist
Testing Performed
Tested by switching to Dark Mode, then unstashing code changes. Setting for Dark Mode remained in local storage, but is now ignored.
With luck, when we re-introduce Dark Mode, and if we use the same local storage flag, users who had saved that preference will get Dark Mode back automatically.
