ROX-16919: Add Contents to GetVulnerabilityRequest#7335
Merged
Conversation
5 tasks
|
Images are ready for the commit at 1c31d6a. To use with deploy scripts, first |
daynewlee
reviewed
Aug 11, 2023
| message NormalizedVersion { | ||
| string kind = 1; | ||
| repeated int32 v = 2; | ||
| message Contents { |
Contributor
There was a problem hiding this comment.
I thought we were calling this reportComponents?
|
@jvdm: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per ADR-0002 #7276, this changes the Matcher proto to receive Contents to request vulnerabilities. When provided, Matcher will generate a report from the contents instead of attempting to pull Index Reports from the Indexer.
Checklist
N/A
If any of these don't apply, please comment below.
Testing Performed
Relying on CI only.