Skip to content

add go mod tidy to each restore cache step#744

Merged
RTann merged 3 commits intomasterfrom
ross/tidy-ci
Feb 24, 2022
Merged

add go mod tidy to each restore cache step#744
RTann merged 3 commits intomasterfrom
ross/tidy-ci

Conversation

@RTann
Copy link
Contributor

@RTann RTann commented Feb 24, 2022

Description

This ensures the go mod cache always exists in steps which may need it. This is useful for the reverted PR which failed CI due to lack of go cache: #742

Checklist

  • Investigated and inspected CI test results
  • [ ] Unit test and regression tests added
  • [ ] Evaluated and added CHANGELOG entry if required
  • [ ] Determined and documented upgrade steps

Testing Performed

CI

@RTann RTann marked this pull request as ready for review February 24, 2022 18:00
@ghost
Copy link

ghost commented Feb 24, 2022

Tag for build #245624 is 3.68.x-278-g85a0b132bc.

💻 For deploying this image using the dev scripts, run the following first:

export MAIN_IMAGE_TAG='3.68.x-278-g85a0b132bc'

📦 You can also generate an installation bundle with:

docker run -i --rm stackrox/main:3.68.x-278-g85a0b132bc central generate interactive > bundle.zip

🕹️ A roxctl binary artifact can be downloaded from CircleCI.

Copy link
Contributor

@gavin-stackrox gavin-stackrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it makes the woes go away I say 🚢
But is there something broken with the cache key that needs to be addressed? goModCacheKey: &goModCacheKey 'rox-go-pkg-mod-v3-{{ checksum "go.sum" }}'

@RTann
Copy link
Contributor Author

RTann commented Feb 24, 2022

If it makes the woes go away I say 🚢 But is there something broken with the cache key that needs to be addressed? goModCacheKey: &goModCacheKey 'rox-go-pkg-mod-v3-{{ checksum "go.sum" }}'

I think the key is ok because we should not use the go cache for an out-dated go.mod/go.sum

@RTann RTann merged commit 31b85e4 into master Feb 24, 2022
@RTann RTann deleted the ross/tidy-ci branch February 24, 2022 20:08
RTann added a commit that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants