Skip to content

test(ui): Adding tests for the deny request workflow#9387

Merged
sachaudh merged 1 commit intomasterfrom
ROX-21009
Jan 22, 2024
Merged

test(ui): Adding tests for the deny request workflow#9387
sachaudh merged 1 commit intomasterfrom
ROX-21009

Conversation

@sachaudh
Copy link
Contributor

@sachaudh sachaudh commented Jan 15, 2024

Description

This PR adds some tests for the deny request workflow

  1. should be able to deny a request if approval permissions are granted
  2. should be able to see how many CVEs will be affected by a denial

@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sachaudh sachaudh force-pushed the ROX-21009 branch 2 times, most recently from ad7a5ce to 32833aa Compare January 15, 2024 19:26
@sachaudh sachaudh marked this pull request as ready for review January 15, 2024 19:27
@sachaudh sachaudh requested a review from a team as a code owner January 15, 2024 19:27
@sachaudh sachaudh requested a review from dvail January 15, 2024 19:27
@sachaudh sachaudh force-pushed the ROX-21009 branch 2 times, most recently from b6d65e8 to b6ad984 Compare January 15, 2024 19:35
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 15, 2024

Images are ready for the commit at 882f872.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.3.x-812-g882f872a2d.

@codecov
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07d1ce8) 47.19% compared to head (882f872) 47.18%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9387      +/-   ##
==========================================
- Coverage   47.19%   47.18%   -0.01%     
==========================================
  Files        2427     2427              
  Lines      164557   164557              
==========================================
- Hits        77659    77653       -6     
- Misses      80491    80495       +4     
- Partials     6407     6409       +2     
Flag Coverage Δ
go-unit-tests 47.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachaudh sachaudh force-pushed the ROX-21009 branch 3 times, most recently from 5962820 to fd07deb Compare January 16, 2024 20:49
@sachaudh sachaudh merged commit b8621c9 into master Jan 22, 2024
@sachaudh sachaudh deleted the ROX-21009 branch January 22, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants