Enhance Job Queue Implementation with Priority-Based Reordering and SwiftDocs Annotations#276
Enhance Job Queue Implementation with Priority-Based Reordering and SwiftDocs Annotations#276admirsaheta wants to merge 3 commits intoswiftwasm:mainfrom
Conversation
|
I have a few comments:
Finally, as this module is a critical part of the concurrency support in WebAssembly, we generally prefer to make changes only if they provide clear benefits, such as fixing bugs or improving performance. For other types of changes, we may be less likely to merge them, but we truly appreciate your contribution and effort. |
|
I understand the concern regarding the dependency on Foundation. I’ll work on removing or replacing the Foundation dependency to reduce the binary size. My goal is to refactor it in a way that is still efficient and works well in the WebAssembly context without adding unnecessary overhead. I’ll make these changes in a day or two and will ensure that the code performs well in this environment. I’ll keep the PR open and continue to iterate on it based on your feedback. Thanks again for your review, and I appreciate your patience. I’m looking forward to getting this working in the most efficient way possible! |
|
Closing this as it’s stale |
This is an update for the #275 Pull Request
This PR introduces the following updates to the job queue implementation in the
JavaScriptEventLoop:1. Priority-Based Job Queue Enhancements
queueLockto handle concurrent job insertion safely.2. Documentation Improvements
3. Code Structure Improvements
UnownedJobwith better encapsulation and type safety.Checked all Github Actions prior on my fork here