PackageToJS: Replace @ts-ignore with @ts-expect-error in templates#643
Open
krodak wants to merge 1 commit intoswiftwasm:mainfrom
Open
PackageToJS: Replace @ts-ignore with @ts-expect-error in templates#643krodak wants to merge 1 commit intoswiftwasm:mainfrom
krodak wants to merge 1 commit intoswiftwasm:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
instantiate.jsuses// @ts-ignore(4 instances) to suppress TypeScript errors onimport.meta.PACKAGE_TO_JS_*properties and the conditionalbridge-js.jsimport. These are inside/* #if */preprocessor blocks, so after preprocessing only some survive into the final output.@ts-expect-erroris stricter than@ts-ignore- it errors if the suppressed line doesn't actually produce a type error, which catches stale suppressions.@ts-ignoresilently swallows everything, including suppressions that are no longer needed.This also resolves
@typescript-eslint/ban-ts-commentviolations in the generated output. The rule bans bare@ts-ignoreby default since@ts-expect-erroris the safer alternative.Line 163 already uses
@ts-expect-errorwith a description - this makes the rest consistent.