Runtime: Enforce prettier formatting, simplify find-global.ts#644
Merged
kateinoigakukun merged 2 commits intoswiftwasm:mainfrom Feb 18, 2026
Merged
Conversation
kateinoigakukun
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The project has prettier installed with a
.prettierrcand aformatscript, but it isn't enforced in CI - so the Runtime source has drifted out of format over time. Swift formatting is already enforced via theformatCI job; this does the same for the TypeScript side.Two changes:
1. Simplify
find-global.tsfind-global.tshas a cascade of fallbacks (globalThis->window->global->self) that hasn't been touched since 2022.globalThisis available in all environments the project targets (Node 12+, all modern browsers), so thewindow/global/selffallbacks are dead code.Before:
After:
2. Apply prettier formatting, add CI check
Runs
npm run format(which already existed) to bring files into compliance, then adds aprettierCI job that runsnpx prettier --check Runtime/src- same pattern as the existing SwiftformatCI job.Split into two commits so the formatting noise is separate from the code change.