BridgeJS: Fix SwiftHeapObject finalization registry leaks and double release#648
Merged
kateinoigakukun merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes two critical issues in BridgeJS's SwiftHeapObject finalization:
- Memory leak from creating a new FinalizationRegistry instance for each object
- Double-release vulnerability when
release()is called multiple times
Changes:
- Refactored SwiftHeapObject to use a shared FinalizationRegistry with state-based tracking
- Made
release()method idempotent to prevent double-release issues - Added test coverage for idempotent release behavior and proper finalization
Reviewed changes
Copilot reviewed 25 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift | Updated SwiftHeapObject template to use shared finalization registry and state-based tracking |
| Tests/prelude.mjs | Added test for idempotent release() behavior |
| Tests/BridgeJSRuntimeTests/SwiftClassSupportTests.swift | Added async test for proper finalization and deallocation |
| Tests/BridgeJSRuntimeTests/Generated/BridgeJS.swift | Generated code for gc() function binding |
| Tests/BridgeJSRuntimeTests/Generated/JavaScript/BridgeJS.json | JSON schema for gc() function |
| Plugins/BridgeJS/Tests/BridgeJSToolTests/Snapshots/BridgeJSLinkTests/*.js (23 files) | Snapshot test files that should reflect the updated SwiftHeapObject implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/SwiftStruct.js
Show resolved
Hide resolved
11ae34d to
012fb6b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 27 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.