Performance improvement on tabs replacement#39
Merged
brendo merged 1 commit intosymphonycms:integrationfrom May 9, 2014
Merged
Performance improvement on tabs replacement#39brendo merged 1 commit intosymphonycms:integrationfrom
brendo merged 1 commit intosymphonycms:integrationfrom
Conversation
…y line instead of for the hole output
Member
|
Initial look is promising, will test on some XML this evening |
brendo
added a commit
that referenced
this pull request
May 9, 2014
Performance improvement on tabs replacement
Member
|
Local tests went well, definitely feels snappier. @michael-e will probably appreciate this the most as he always deals with massive amounts of XML! Thanks @nitriques! |
Member
Author
|
You're welcome! |
Member
Unless I break it. :-) No, honestly, sounds good! I had to get used to |
Member
Author
|
Great! If you spot a bug, please let me know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It processes the regex line by line instead of for the hole output, which drastically reduce the memory consumption.
I had a page with an 8000 line xml that refuses to render under 30 seconds. With this fix, it now renders properly in 7 secs.
Using
strstrin a while loop is evil too. Usingstrposis way better (as stated in the php docs).