Revert "nspawn: remove unnecessary mount option parsing logic"#13173
Merged
yuwata merged 2 commits intosystemd:masterfrom Jul 25, 2019
Merged
Revert "nspawn: remove unnecessary mount option parsing logic"#13173yuwata merged 2 commits intosystemd:masterfrom
yuwata merged 2 commits intosystemd:masterfrom
Conversation
This reverts commit 72d967d. Revert this because it broke the `norbind` option of the bind flags because it does bind-mounts unconditionally recursive. Let's bring the old logic back. Fixes: systemd#13170
This regressed so let's add a test to make sure it doesn't happen again.
a232306 to
5574181
Compare
Contributor
Contributor
|
In the meantime, I triggered bionic-amd64 manually here. |
Contributor
I don't have access to the lab where the Ubuntu CI runs, but there were (and apparently still are) problems in the lab I do have access to. The Canonical infrastructure team is working on it; I don't think there is anything I'm able to do, although it seems like the production lab where Ubuntu CI runs is working better now. |
|
Sorry I'm at Debconf right now and so I don't have very good availability this week. I checked a couple of other recent PRs (#13176 and #13175) which seem to have gone OK - did this resolve itself? I can see some |
Contributor
Member
|
|
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 25, 2019
There was a bug w.r.t. the `norbind` option of bind mount options in systemd, so we need backport the upstream fix to v241. See systemd/systemd#13173
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 25, 2019
There was a bug w.r.t. the `norbind` option of bind mount options in systemd, so we need backport the upstream fix to v241. See systemd/systemd#13173
This was referenced Jul 25, 2019
Merged
agermain
added a commit
to agermain/rkt
that referenced
this pull request
Aug 7, 2019
As CoreOS Container Linux is in maintenance mode (coreos/bugs#2559 (comment)) and won't see many new features and we need some systemd bugfixes that rkt needs (specifically systemd/systemd#13173 and systemd/systemd#12860) let's switch to Flatcar Linux. Flatcar Linux us a drop-in replacement of Container Linux and its Edge channel contains the needed bugfixes. To do that, we need to change the GPG key to verify the images through the script.
agermain
added a commit
to agermain/rkt
that referenced
this pull request
Aug 7, 2019
As CoreOS Container Linux is in maintenance mode (coreos/bugs#2559 (comment)) and won't see many new features and we need some systemd bugfixes that rkt needs (specifically systemd/systemd#13173 and systemd/systemd#12860) let's switch to Flatcar Linux. Flatcar Linux us a drop-in replacement of Container Linux and its Edge channel contains the needed bugfixes. To do that, we need to change the GPG key to verify the images through the script.
agermain
added a commit
to agermain/rkt
that referenced
this pull request
Aug 9, 2019
As CoreOS Container Linux is in maintenance mode (coreos/bugs#2559 (comment)) and won't see many new features and we need some systemd bugfixes that rkt needs (specifically systemd/systemd#13173 and systemd/systemd#12860) let's switch to Flatcar Linux. Flatcar Linux us a drop-in replacement of Container Linux and its Edge channel contains the needed bugfixes. To do that, we need to change the GPG key to verify the images through the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 72d967d.
Revert this because it broke the
norbindoption of the bind flagsbecause it does bind-mounts unconditionally recursive.
Let's bring the old logic back.
Also, add a test for this.
Fixes: #13170