Skip to content

Filter metrics by function in InferenceFilterBuilder #5581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Nfemz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Filter metrics by function in InferenceFilterBuilder #5581

Nfemz wants to merge 1 commit into from

Conversation

@Nfemz
Copy link

@Nfemz Nfemz commented Jan 9, 2026 •
edited
Loading

Addresses: #5154

Dataset Builder - Loom Video
Inference Table Filter - Loom Video

When a function is selected, the metric popover now only shows metrics that have feedback data for inferences of that function, rather than showing all metrics from config.

  • Add optional functionName prop to InferenceFilterBuilder
  • Fetch metrics with feedback using existing endpoint
    • without much context this could result in over-fetching. This would mean original idea of a new endpoint may still be the correct move
  • Show loading spinner while fetching
  • Pass functionName from DatasetBuilderForm, InferencesTable, and
    InferenceQueryBuilder

Important

Enhance InferenceFilterBuilder to filter metrics by function, updating UI components to support function-specific metric fetching and display.

  • Behavior:
    • InferenceFilterBuilder now filters metrics by functionName prop, fetching metrics with feedback for the selected function.
    • Displays a loading spinner while fetching metrics.
    • Updates metric popover to show only relevant metrics.
  • Components:
    • Adds functionName prop to InferenceFilterBuilder, InferenceQueryBuilder, DatasetBuilderForm, and InferencesTable.
    • Uses useFetcher in InferenceFilterBuilder to load metrics.
  • UI:
    • Shows loading spinner in AddMetricPopover while fetching.
    • Updates CommandEmpty message in AddMetricPopover to reflect filtered metrics.

This description was created by Ellipsis for d86119b. You can customize this summary. It will automatically update as commits are pushed.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Nfemz
Copy link
Author

Nfemz commented Jan 9, 2026

I have read the Contributor License Agreement (CLA) and hereby sign the CLA.

github-actions bot added a commit that referenced this pull request Jan 9, 2026
@github-actions
@Nfemz has signed the CLA in #5581
92c4893
Nfemz
Nfemz commented Jan 9, 2026
View reviewed changes
ui/app/components/querybuilder/InferenceFilterBuilder.tsx
`/api/function/${encodeURIComponent(functionName)}/feedback_counts`,
);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
Copy link
Author

@Nfemz Nfemz Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following existing codebase patterns - not clear whether or not metricsFetcher is a stable reference.

@Nfemz
Copy link
Author

Nfemz commented Jan 9, 2026

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Jan 9, 2026

To use Codex here, create a Codex account and connect to github.

@GabrielBianconi GabrielBianconi self-assigned this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GabrielBianconi GabrielBianconi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nfemz @GabrielBianconi