Add type assertion to the cache lookup#123
Merged
masklinn merged 1 commit intoua-parser:masterfrom Aug 15, 2022
Merged
Conversation
6f95648 to
1866aa2
Compare
Currently if an incorrect type is passed in, it'll raise an error that's anything but clear, either failing in the cache lookup or in the regex application. Instead, make the error clear by checking upfront. Closes ua-parser#122
1866aa2 to
d0ca1df
Compare
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Aug 20, 2022
- removed version bound from `setup_requires`, allows building from source when only PyYaml 6.0 is available (and downloading 5.4 is not), ua-parser#121, ua-parser#125 - added type assertion to parser lookup, to make the error clearer on type error, ua-parser#122, ua-parser#123 - fixed `setup.py build_regexes` and `setup.py build` for non-in-place builds, ua-parser#127
Merged
masklinn
added a commit
that referenced
this pull request
Aug 20, 2022
- removed version bound from `setup_requires`, allows building from source when only PyYaml 6.0 is available (and downloading 5.4 is not), #121, #125 - added type assertion to parser lookup, to make the error clearer on type error, #122, #123 - fixed `setup.py build_regexes` and `setup.py build` for non-in-place builds, #127
|
|
||
| def _lookup(ua, args): | ||
| if not isinstance(ua, _UA_TYPES): | ||
| raise TypeError("Expected user agent to be a string, got %r" % ua) |
There was a problem hiding this comment.
shouldn't that be type(ua) at the end?
Contributor
Author
There was a problem hiding this comment.
Shouldn't really matter, this prints the value which I assumed would be more relevant / understandable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if an incorrect type is passed in, it'll raise an error that's anything but clear, either failing in the cache lookup or in the regex application.
Instead, make the error clear by checking upfront.
Closes #122