Noop scope#40
Conversation
|
@JigarJoshi do you know who should be code reviewing this? |
|
|
||
| @Override | ||
| public Counter counter(String name) { | ||
| return (delta) -> { |
There was a problem hiding this comment.
this might create a new lambda object every time [ not sure it the compiler will inline this ]. you could instantiate a static function protected final Provider<Counter> PROVIDER_FUNCTION = () -> {} and reuse
There was a problem hiding this comment.
same goes for all of the other NoOp methods
There was a problem hiding this comment.
good point. I updated the PR.
willsalz
left a comment
There was a problem hiding this comment.
ship it! I didn't see any other reviewers active on this diff, and I'm not sure who actively watches this project, but feel free to land and we can improve as needed.
|
|
||
| @Override | ||
| public Counter counter(String name) { | ||
| return (delta) -> { |
There was a problem hiding this comment.
same goes for all of the other NoOp methods
|
@JigarJoshi looks mostly good, thanks! Looks like the build is red because checkstyle is complaining about the missing copyright statement at the beginning of the file. Can you put that in please? Copy it from some other file but use 2019 as the year. FYI when it says something like |
#34