remove global lock for subscope computation#53
Merged
justinjc merged 1 commit intouber-java:masterfrom Feb 19, 2020
Merged
Conversation
|
|
sairamch04
added a commit
to sairamch04/tally
that referenced
this pull request
Feb 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our application the metric tags are dynamic, so we end up calling ScopeImpl#tagged api for the subscope, each time a metric in emitted. We have upto 10^5 metric series in one environment. The global lock is resulting in many threads in blocked state.
Moving to concurrentHashMap, we atmost put a read-write lock on a particular bucket rather than whole object.