Skip to content

fix problem eth_estimateGas #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctrpsrf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix problem eth_estimateGas #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion uniswap/uniswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,7 @@ def _build_and_send_tx(
tx_params = self._get_tx_params()
transaction = function.build_transaction(tx_params)

if "gas" not in tx_params:
if "gas" not in transaction:
# `use_estimate_gas` needs to be True for networks like Arbitrum (can't assume 250000 gas),
# but it breaks tests for unknown reasons because estimate_gas takes forever on some tx's.
# Maybe an issue with ganache? (got GC warnings once...)
Expand Down