V4 support beta #418
Open
V4 support beta #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pool manager contract ABI
Deleted due to naming fix
Deleted due to naming fix
Deleted due to naming fix
Deleted due to naming fix
Deleted due to naming fix
Naming fix
Liquidity pools list management class added, UniswapV4 improvements.
ErikBjare
approved these changes
Jan 16, 2026
Member
ErikBjare
left a comment
There was a problem hiding this comment.
Generally approved. Haven't checked why CI is failing yet.
Could use some auto-formatting by ruff.
Member
|
Ah, I see CI is failing due to outdated actions. I think we can merge this and address the outdated CI and any CI issues related to this PR in follow-up. |
ErikBjare
reviewed
Jan 16, 2026
Member
There was a problem hiding this comment.
Do we really want inis for this? Are we expecting users to be able to modify them? Why not just use a global dict in a .py?
ErikBjare
reviewed
Jan 16, 2026
Comment on lines
+371
to
+376
| def build_execute_params(self,): | ||
| """ | ||
| Generic parameters builder for universal router execute() call. | ||
| WIP | ||
| """ | ||
| pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic functionality, like price fetching, quoting, and making simple swaps etc