Skip to content

Conversation

@ErikBjare
Copy link
Member

Very WIP.

@ErikBjare ErikBjare mentioned this pull request Jan 20, 2021
@ErikBjare
Copy link
Member Author

ErikBjare commented Jan 20, 2021

As I mentioned in #62, it might be better to add the ability to override the router and factory contract addresses from the constructor parameters (since it generalizes support across all Uniswap clones).

@ErikBjare ErikBjare changed the title feat: initial support for Honeyswap (on xDai) feat: initial support for Honeyswap (on xDai) and specific routes Jan 20, 2021
@ErikBjare ErikBjare mentioned this pull request Feb 22, 2021
@ErikBjare ErikBjare mentioned this pull request Apr 27, 2021
@ErikBjare ErikBjare changed the title feat: initial support for Honeyswap (on xDai) and specific routes feat: initial support for custom deployments May 4, 2021
@ErikBjare ErikBjare marked this pull request as ready for review May 4, 2021 12:13
@ErikBjare
Copy link
Member Author

Tests pass locally (after fixing what I thought was the cause of #88). Not sure why they don't work in CI.

Maybe because the token is secret and not available in PRs?

Works now anyway, merging.

@ErikBjare ErikBjare merged commit 00c77d6 into uniswap-python:master May 4, 2021
@ErikBjare ErikBjare deleted the dev/honeyswap branch May 4, 2021 12:13
This was referenced May 4, 2021
@ErikBjare ErikBjare changed the title feat: initial support for custom deployments feat: initial support for custom deployments and routes May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant