Skip to content

fix: slippage in _eth_to_token_swap_output #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Apr 1, 2021
Merged

fix: slippage in _eth_to_token_swap_output #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion uniswap/uniswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ def _eth_to_token_swap_output(
else:
if recipient is None:
recipient = self.address
eth_qty = self.get_eth_token_output_price(output_token, qty)
eth_qty = int((1 + self.max_slippage)*self.get_eth_token_output_price(output_token, qty))
return self._build_and_send_tx(
self.router.functions.swapETHForExactTokens(
qty,
Expand Down