Skip to content

feat: support cloning from http(s) inputs#129

Merged
pi0 merged 1 commit intomainfrom
feat/http-source
Dec 23, 2023
Merged

feat: support cloning from http(s) inputs#129
pi0 merged 1 commit intomainfrom
feat/http-source

Conversation

@pi0
Copy link
Member

@pi0 pi0 commented Dec 23, 2023

🔗 Linked issue

resolves #10

previous works #86, #91 ❤️

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds support for input to using http:// or https:// protocols.

If the path ends with .json or a response content type with HEAD method is application/json or text/plain for the sake of GH raw content (reverted in 1945818), we download JSON as Template info.

Otherwise we try to guess name from URL's last segment (basename) or content-disposition filename header if provided in HEAD response as default name.

The fragment support as proposed in initial issue is not implemented as I think with JSON support now we have enough power to control responses without making inputs more complex but PR welcome if there are valid cases for it.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

built-in tar: provider

1 participant