Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
===========================================
- Coverage 54.63% 43.82% -10.81%
===========================================
Files 7 6 -1
Lines 615 470 -145
Branches 47 47
===========================================
- Hits 336 206 -130
+ Misses 278 263 -15
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Hi. Sorry for delay on this. I mainly wanted to double check if both with and without subgroups it works and didn't had a chance to make a testing gitlab structure yet. If you have some it can be helpful to speedup landing this 🙏🏼 |
|
Hi @sl0wik . Thanks for that fix. It helps me a lot. To be compatible with the latest giget version v1.2.3 your fix need to be updated a little: |
|
When The |
This comment was marked as off-topic.
This comment was marked as off-topic.
| url: `${gitlab}/${parsed.repo}/tree/${parsed.ref}${parsed.subdir}`, | ||
| tar: `${gitlab}/${parsed.repo}/-/archive/${parsed.ref}.tar.gz`, | ||
| url: `${gitlab}/${parsed.repo}${parsed.subdir}/tree/${parsed.ref}`, | ||
| tar: `${gitlab}/${parsed.repo}${parsed.subdir}/-/archive/${parsed.ref}.tar.gz`, |
There was a problem hiding this comment.
this is currently generating with //
{
name: 'unjs-template',
version: 'main',
subdir: '/',
headers: { authorization: undefined, 'sec-fetch-mode': 'same-origin' },
url: 'https://gitlab.com/unjs/template//tree/main',
tar: 'https://gitlab.com/unjs/template//-/archive/main.tar.gz'
}|
Any updates on this? |
|
@ColiZei I've created a new PR since this seems not fixed #246. If @pi0 can review that one and approve it will be really helpful for my work too. As a workaround here what i did in my Nuxt projects nuxt-config.ts extends: [
[
"providerName:latest",
{
giget: {
provider: "providerName",
providers: {
providerName: async (input, { auth }) => {
return {
name: "providerName",
version: input,
headers: {
authorization: `Bearer ${auth}`,
"sec-fetch-mode": "same-origin",
},
url: `https://gitlab.com/company/subgroup/repo-name/-/tree/main`,
tar: `https://gitlab.com/company/subgroup/repo-name/-/archive/main/repo-name.tar.gz`,
};
},
},
},
},
],
],
|
🔗 Linked issue
#107
❓ Type of change
📚 Description
Gitlab supports nested subgroups, like
https://gitlab.com/{groupName}/{subgroupName}/{repoName}. Attempting to pull any subgroup would result in a 403 error. This pull request resolves the issue.📝 Checklist