fix!: use correct temp dir in windows for cache#182
Conversation
store template cache within the windows user's temp directory (%temp%)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 54.63% 45.60% -9.04%
==========================================
Files 7 6 -1
Lines 615 500 -115
Branches 47 48 +1
==========================================
- Hits 336 228 -108
+ Misses 278 272 -6
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
pi0
approved these changes
Feb 25, 2025
pi0
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #178
On Windows, the template cache is moved to the user's temp directory (%temp%/giget). This follows the correct OS conventions and allows Windows storage utils (Disk Clean-up, Storage Sense) to delete the cache to free storage if the user desires.
It will move the cache directory if oldDir && !newDir. This logic requires running
resolve()to get both the Windows and other OS cache paths at the same time andexistsSync()twice on Windows. We remove the migration code after some time in the future, and simplify to437adc3(#182)