Open
Conversation
fetch[method](url) aliases
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
===========================================
+ Coverage 56.86% 70.05% +13.18%
===========================================
Files 16 17 +1
Lines 728 531 -197
Branches 113 137 +24
===========================================
- Hits 414 372 -42
+ Misses 303 148 -155
Partials 11 11 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks for nice PR dear @Kiansa. I'm gonna some time to think about API and overhead but positive about DX benefits. |
|
@pi0 any plans to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the
fetchfunction in thesrc/fetch.tsfile to add method aliases for common HTTP verbs. The aliases includeget,post,put,delete,patch,head, andoptions. These aliases simplify the usage of thefetchfunction by allowing developers to use more intuitive method names instead of manually specifying the HTTP method in the options object.The changes also include updating the
types.tsfile to define theFetchWithAliasestype, which extends the existing$Fetchtype and adds the method aliases as properties.This enhancement improves the readability and maintainability of the codebase by providing a more expressive and concise API for making HTTP requests.
Closes #282