Skip to content

fix(parse): handle empty values#86

Merged
pi0 merged 3 commits intounjs:mainfrom
savoygu:fix/trim
Apr 9, 2024
Merged

fix(parse): handle empty values#86
pi0 merged 3 commits intounjs:mainfrom
savoygu:fix/trim

Conversation

@savoygu
Copy link
Contributor

@savoygu savoygu commented Aug 4, 2023

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Using updateUser({ key: '' }, config) to update the configuration saves the key= in the local config file, which causes:

图片

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

pi0
pi0 approved these changes Aug 4, 2023
@pi0 pi0 changed the title fix: empty string value not being trimmed fix(parse): handle empty values Apr 9, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 150d658 into unjs:main Apr 9, 2024
@savoygu savoygu deleted the fix/trim branch October 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants