fix(withBase, withoutBase): prevent false prefix matches#313
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
+ Coverage 95.27% 96.82% +1.55%
==========================================
Files 7 6 -1
Lines 867 472 -395
Branches 187 155 -32
==========================================
- Hits 826 457 -369
+ Misses 41 14 -27
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: nuxt/nuxt#33924
Summary
While investigating nuxt/nuxt#33924, I found that
withoutBasewas being a bit too eager when stripping base URLs.The issue: When using
baseURL: '/admin/'with a page like/admin-dashboard, the function incorrectly stripped/adminbecause it only checkedstartsWith()without verifying that the match ends at a path segment boundary.The fix: Added a simple check to ensure the character after the base is either /, ?, or end of string before treating it as a valid base match.
Test plan
Update⚠️
Same issue is in
withBaseas well. I also fixed it and added new tests.