refactor(node:tty): standalone implementations#488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(context: found while investigating nuxt-hub/core#499)
Current
ReadStream/WriteStreampolyfill implementations used forprocess.std{in,out,err}polyfills are extendingnode:netwrongly.This causes not only extra bundle impact when not used (in pure polyfill mode) but also is the wrong extension as
ttyis not a network socket and also internal cycling dependencies.Also
process.std{out,err}.writewas completely nonfunctional.I have implemented both as partial types with
WriteStream.writeredirect to realconsoleas polyfill.I don't expect any libraries in compat mode to expect more tty methods but we can later explicitly implement/mock them if needed. Alternatively, overlay presets can check implementation.