Skip to content

fix(node:cluster): minor fixes #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 3 commits into from
Oct 13, 2025
+11 −9
Merged

fix(node:cluster): minor fixes #521

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0c98f6
fix(cluster): a few fixes
vicb Oct 13, 2025
be4d17b
fixup! add return type
vicb Oct 13, 2025
55d5a06
fixup: any
vicb Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/runtime/node/cluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type nodeCluster from "node:cluster";
import type {
Cluster as NodeCluster,
Worker as NodeClusterWorker,
ClusterSettings as NodeClusterSettings,
} from "node:cluster";
import { EventEmitter } from "node:events";
import { notImplemented } from "../_internal/utils.ts";
Expand Down Expand Up @@ -58,8 +59,9 @@ export class Worker extends EventEmitter implements NodeClusterWorker {
destroy(signal?: string): void {
this._connected = false;
}
disconnect(): void {
disconnect(): this {
this._connected = false;
return this;
}
}

Expand All @@ -73,17 +75,17 @@ class _Cluster extends EventEmitter implements NodeCluster {
schedulingPolicy = SCHED_RR;
settings = settings;
workers = workers;
setupPrimary() {
return setupPrimary();
setupPrimary(_settings?: NodeClusterSettings): void {
setupPrimary();
}
setupMaster() {
return setupPrimary();
setupMaster(_settings?: NodeClusterSettings): void {
setupMaster();
}
disconnect() {
return disconnect();
disconnect(): void {
disconnect();
}
fork() {
return fork();
fork(env?: any): NodeClusterWorker {
return fork(env);
}
}

Expand Down